Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ngx-moveable broken after 0.38.0, previous 0.37.1 works great, see video #856

Closed
born2net opened this issue Mar 5, 2023 · 13 comments
Closed
Labels
Angular bug Something isn't working complete
Milestone

Comments

@born2net
Copy link

born2net commented Mar 5, 2023

As you can see from the attached gif, in Angular project all is well in version 0.37.1
As soo as we move to 0.38.+ or greater multi select is broken things jump around and resize to top and also we can drag outside the ruler area, all these issues work fine in 0.37.1....

is anyone else seeing this? Is there broking changes we need to change? ( I don't think as we still in minor version change)

Thanks for a great project,

moveable

@daybrush
Copy link
Owner

daybrush commented Mar 5, 2023

@born2net

Can you briefly tell the code of onDragGroup?

Or can you reproduce the problem via codesandbox?

@born2net
Copy link
Author

born2net commented Mar 6, 2023

sure here you go:

image

@born2net
Copy link
Author

born2net commented Mar 6, 2023

I am now printing the console.log left / top so you can see that values received are wrong:
(click gif to see full screen)
dragGroup

@born2net
Copy link
Author

born2net commented Mar 7, 2023

any more info needed? tx!

@daybrush
Copy link
Owner

daybrush commented Mar 7, 2023

@born2net

I figured out the cause of the bug.
It will be released within this week.

@daybrush daybrush added bug Something isn't working and removed checking labels Mar 7, 2023
@daybrush daybrush added this to the 0.44.0 milestone Mar 7, 2023
daybrush added a commit that referenced this issue Mar 7, 2023
@born2net
Copy link
Author

born2net commented Mar 8, 2023

thank you, I am just wondering why no one else reported this?
this has been since 0.38 and clearly MANY people use this lib. any ideas?

Also is there a way for us to test build 0.44 with the fix?

TX for an amazing lib,

Sean.

@daybrush
Copy link
Owner

daybrush commented Mar 8, 2023

@born2net

Maybe it's because you're using a transform other than left or top.

@daybrush
Copy link
Owner

daybrush commented Mar 8, 2023

@born2net

ngx-moveable's new version is released.

Update and test again.

thank you :)

@born2net
Copy link
Author

born2net commented Mar 8, 2023

Hi...
I tested "ngx-moveable": "^0.40.1", but unfortunately I am seeing the same behavior, jumps right onto the cornet on group drag :(

@daybrush
Copy link
Owner

daybrush commented Mar 9, 2023

@born2net

ngx-moveable's latest version is 0.41.0. Test 0.41.0 version/

@born2net
Copy link
Author

born2net commented Mar 9, 2023

I now tried version "ngx-moveable": "^0.41.0", and I am sorry to report that the issue still persists.
it's still jumps to corner on multi selection.
Is it possible that the fixes didn't go into Angular ngx version?
88c9ec2

I looked for:

grep -r -i "getRequestChildStyles" ./ngx-moveable/

in 0.41 but didn't see it, so not sure.

thanks again,

Sean.

@daybrush
Copy link
Owner

daybrush commented Mar 9, 2023

@born2net

[email protected] is released. Check it again.

This correction was not reflected properly and was reflected again.

daybrush added a commit that referenced this issue Mar 9, 2023
@born2net
Copy link
Author

born2net commented Mar 9, 2023

u r d man!
fixed it!!!
TX for the best lib!!!
Sean <3

@born2net born2net closed this as completed Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Angular bug Something isn't working complete
Projects
None yet
Development

No branches or pull requests

2 participants