Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: resizable: true, edge: true prevents roundClickable: true from working #761

Closed
SidIcarus opened this issue Oct 10, 2022 · 3 comments
Closed

Bug: resizable: true, edge: true prevents roundClickable: true from working #761

SidIcarus opened this issue Oct 10, 2022 · 3 comments
Labels
bug Something isn't working complete Feature
Milestone
0.37.0

Comments

@SidIcarus
Copy link

SidIcarus commented Oct 10, 2022 •
edited
Loading

Environments

  • Framework name: vanillaJS
  • Moveable Component version: 0.36.4
  • Testable Address(optional): Codepen

I believe my problem in the linked issue was the explicitly set border-radius: 0 and this issue.

Originally posted by @SidIcarus in #756 (comment)
@daybrush daybrush added this to the 0.36.4 milestone Oct 11, 2022
@daybrush daybrush added bug Something isn't working Feature labels Oct 11, 2022
@daybrush
Copy link
Owner

@SidIcarus

well it's hard

I will improve Roundable.

I will change the position of the round control like figma.
image

@daybrush daybrush modified the milestones: 0.36.5, 0.37.0 Oct 11, 2022
daybrush added a commit that referenced this issue Oct 17, 2022
@daybrush
feat: add roundPadding, isDisplayShadowRoundControls #761 #762
68be2e8
daybrush added a commit that referenced this issue Oct 17, 2022
@daybrush
fix: fix border radius for line #761
803f0b6
@daybrush
Copy link
Owner

@SidIcarus

The round addition function through double-clicking the edge and line cannot be used at the same time.

But you can use isDisplayShadowRoundControls={true or "horizontal"} , roundPadding

https://daybrush.com/moveable/storybook2/?path=/story/basic--roundable

@SidIcarus
Copy link
Author

This is a huge improvement! isDisplayShadowRoundControls is very cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working complete Feature
Projects
None yet
Milestone
0.37.0
Development

No branches or pull requests
2 participants
@daybrush @SidIcarus