Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong bounds position when changing scale, css positioning, transform-origin #699

Closed
mdominiak2 opened this issue Jul 14, 2022 · 4 comments
Closed

Wrong bounds position when changing scale, css positioning, transform-origin #699

mdominiak2 opened this issue Jul 14, 2022 · 4 comments
Labels
bug Something isn't working complete enhancement New feature or request
Milestone
0.32.0

Comments

@mdominiak2
Copy link

mdominiak2 commented Jul 14, 2022 •
edited
Loading

Environments

Description

Moveable allows to move an element out of the container.
The problem also occurs without transform: scale.
Any advice?

image
@mdominiak2
Copy link
Author

I think I solved the problem by adding a container with a specific css style.

But still there are some imperfections when I change transform-origin to center

https://codesandbox.io/s/magical-mirzakhani-b17ts7?file=/index.html

image

@mdominiak2
Copy link
Author

If I avoid using display: flex and transform-origin: center everything is ok. But when I want to center the drag area, I get the same bug again.

https://codesandbox.io/s/gifted-matsumoto-7zhe67?file=/src/styles.css

image

@daybrush daybrush added this to the 0.31.3 milestone Jul 19, 2022
@daybrush daybrush added WIP-complete WIP bug Something isn't working enhancement New feature or request and removed WIP-complete labels Jul 20, 2022
daybrush added a commit that referenced this issue Jul 20, 2022
@daybrush
test: test drag accuracy #699
9c7e8c7
daybrush added a commit that referenced this issue Jul 21, 2022
@daybrush
fix: enhance bounds accuracy #699
9aee6bd
@daybrush daybrush added complete and removed WIP labels Jul 21, 2022
@daybrush
Copy link
Owner

@mdominiak2

  • lit-moveable 0.9.0
  • moveable 0.32.0
  • preact-moveable 0.34.0
  • react-compat-moveable 0.20.0
  • react-moveable 0.35.0
  • svelte-moveable 0.24.0
  • vue-moveable 2.0.0-beta.26
  • vue3-moveable 0.7.0
  • ngx-moveable 0.29.0

moveable's new version is released. Check it again.

It may not be perfect, but it has improved the accuracy a lot.

@mdominiak2
Copy link
Author

Thanks. Great job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working complete enhancement New feature or request
Projects
None yet
Milestone
0.32.0
Development

No branches or pull requests
2 participants
@daybrush @mdominiak2