Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref prop type #141

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix ref prop type #141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1741f62
Fix ref prop type
OliverJAsh Nov 5, 2020
c95c6bf
Use `object` instead for SSR
OliverJAsh Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/propTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ const PropTypes = require("prop-types");
module.exports = {
refType: PropTypes.oneOfType([
PropTypes.func,
PropTypes.shape({ current: PropTypes.elementType })
PropTypes.shape({ current: PropTypes.object })
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elementType refers to a React element, but here we may have a DOM element.

I initially tried to fix this using PropTypes.oneOfType([PropTypes.elementType, PropTypes.instanceOf(Element)]), but this broke when the code was ran on the server, as Element does not exist as a global there.

])
};