-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with react-native-web #455
Open
Spoutnik97
wants to merge
1
commit into
davidohayon669:master
Choose a base branch
from
Spoutnik97:react-native-web
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all features are note implemented, but this PR avoid to crash when using with react-native-web. Moreover it provides the last official YouTube player
This was referenced Jun 5, 2020
Open
Spoutnik97
changed the title
✨ (YouTube.web.js) add compatibility with react-native-web
Add compatibility with react-native-web
Jun 5, 2020
marcioluiz
approved these changes
Jul 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PedroPovedaQ
approved these changes
Dec 15, 2020
xterikatx
approved these changes
Apr 14, 2021
@davidohayon669 up to merge it please ? |
Can this PR be merged? It would be nice to have basic web support. |
+1 |
Would also love to see this merged soon :) |
@davidohayon669 @maskaravivek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all features are note implemented, but this PR avoids to crash when using with react-native-web.
Moreover it provides the last official YouTube player