Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android fullscreen fix #128

Closed
wants to merge 5 commits into from
Closed

Android fullscreen fix #128

wants to merge 5 commits into from

Conversation

lucianomlima
Copy link
Contributor

Resolves the issue with fullscreen on Android when close vídeo by device back button.
Fix #114

@davidohayon669
Copy link
Owner

davidohayon669 commented Mar 15, 2017

Does this happens also on the v1 branch?
Can you resolve it for the v1 branch as well?
v1 will pretty soon be the master branch

@lucianomlima
Copy link
Contributor Author

I'll check and answer later

@lucianomlima
Copy link
Contributor Author

lucianomlima commented Mar 15, 2017

@davidohayon669 I checked the v1 branch and for now my PR only fix issue on master branch.
v1 branch have a different organization (and have a ReactModule).
But I test the v1 branch and the problems persist. When open a video in fullscreen and press device back button, the orientation blocks on landscape.
I'll send a PR to branch v1 tomorrow.

This PR, configures setFullscreenControlFlags on YouTubePlayer and reset the orientation to device default.

Question, I see that in v1 branch was removed YouTubePlayer.OnFullscreenListener. What is the reason?

@davidohayon669
Copy link
Owner

No special reason, we can get it back. Its just that I removed a lot of stuff to have cleaner code so I can apply features more smart

@davidohayon669
Copy link
Owner

v0.x is history

@ziyafenn
Copy link

Was it never merged? The problem still exists with android hardware button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android FullScreen Hardware Back Button locks orientation to landscape
3 participants