Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move portal-experiment into portal and refactor #59

Closed
8 tasks done
risenW opened this issue Mar 4, 2021 · 1 comment
Closed
8 tasks done

Move portal-experiment into portal and refactor #59

risenW opened this issue Mar 4, 2021 · 1 comment
Assignees
@rufuspollock @risenW

Comments

@risenW
Copy link
Contributor

risenW commented Mar 4, 2021 •
edited by rufuspollock
Loading

Move and refactor portal-experiment into portal.js

We already have older packages/portal which is currently more of an example of a full data catalog site running on nextjs. We want to keep this and move it to examples/catalog

Our new portal experiment should then become the main portal package in packages/portal so we can focus on developing there.

Acceptance

  • packages/portal moved to examples/catalog DONE
  • I have portal-experiment integrated into portal.js repo DONE. located at packages/portal. Have also integrated the CLI into that package.
  • updated main README to reflect this DONE. Main README is stubbed atm

Task

  • Agree on repo we are using DONE. We agreed to move portal-experiment into portal.js
  • Clean up the portal repo
    • Move packages/portal to examples/catalog
    • Refactor README to explain this is an example
    • Reboot portal sub package with README
@risenW risenW self-assigned this Mar 4, 2021
This was referenced Mar 4, 2021
Closed
Closed
Closed
rufuspollock added a commit that referenced this issue Mar 6, 2021
@rufuspollock
[refactor,#59][s]: move packages/portal => examples/catalog as per pl…
337d4a8 
…an in #59.

What is currently packages/portal is example of a running portal and should move to examples (it will get replaced by an actual portal lib soon).
rufuspollock added a commit that referenced this issue Mar 7, 2021
@rufuspollock
[portal,#59][l]: new portal package that (right now) presents a singl…
5fcdfa2 
…e dataset.

* What we have is a nextjs app for displaying a single dataset (+ tests, +fixtures etc)
* Also included are relevant generic components (e.g. a Chart and Table view) and some utilities for loading (Frictionless) datasets
* Not include (but to come) is the command line app
rufuspollock added a commit that referenced this issue Mar 7, 2021
@rufuspollock
[portal,#59][s]: add the in-progress portal cli.
782e888 
NB: portal CLI is currently a bit broken (it starts but some errors) as needs a bit more work to refactor for new location in this repo. Have not done all this refactoring as probably bigger changes needed.
rufuspollock added a commit that referenced this issue Mar 7, 2021
@rufuspollock
[#59,refactor][s]: consolidate on yarn.lock at top level as per monor…
58b0132 
…epo practice.
@rufuspollock
Copy link
Member

FIXED. All merged in (see acceptance).

@rufuspollock rufuspollock self-assigned this Mar 11, 2021
@rufuspollock rufuspollock mentioned this issue Mar 11, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rufuspollock rufuspollock

@risenW risenW

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rufuspollock @risenW