Add Structs support for SQLite #70
Merged
+110
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite does not support Structs natively so PRs adds fallback on using JSON column type and serialization to JSON string for Arrow struct type.
With this change previously unsupported Arrow Struct type will be stored and retrieved as Utf8 string when queried directly or automatically converted to Arrow Struct type when using casting layer: spiceai/datafusion-federation#16
Integration tests for struct will be enabled after casting PR is merged and reference is updated: spiceai/datafusion-federation#16
PR also switches from own
try_cast_toimplementation totry_cast_toexposed by datafusion-federation