Streaming write for DuckDB TableProvider #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
force-pushed
the
sgrebnov/duckdb-streaming-write
branch
from
f97a781 to
a023db7
Compare
sgrebnov
force-pushed
the
sgrebnov/duckdb-streaming-write
branch
from
26589b5 to
f0d147e
Compare
sgrebnov
commented
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR implements streaming write support for the DuckDB
TableProvider, which is critical for handling large volumes of data that cannot be stored entirely in memory before writing to a DuckDB file-basedTableProvider.Since DuckDB transactions are not
Sync, they cannot be used in the asynchronous context required for stream reading. To address this, a separate Tokio task has been created for synchronous DuckDB writing. Atokiochannel withblocking_recvis used to propagateRecordBatchesfor writing.