Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve timezone information in arrow type - pg type conversion #59

Merged
merged 8 commits into from
Aug 22, 2024
Merged

Preserve timezone information in arrow type - pg type conversion #59

merged 8 commits into from
Aug 22, 2024
+461 −197

Conversation

Sevenannn
Copy link
Contributor

@Sevenannn Sevenannn commented Aug 21, 2024 •
edited
Loading

  • Preserve timezone information when converting arrow timestamp(timeunit, timezone) type to sql rows
  • Correctly convert Postgres Timestamptz type back to arrow type with time zone information, this fixes the incorrect conversion from pg row -> arrow caused by neglecting timezone information
  • Refactor the roundtrip integration test to values check using try_cast_to

phillipleblanc
phillipleblanc approved these changes Aug 22, 2024
View reviewed changes
tests/arrow_record_batch_gen/mod.rs Outdated Show resolved Hide resolved
@phillipleblanc phillipleblanc merged commit f5cff39 into datafusion-contrib:main Aug 22, 2024
3 checks passed
@Sevenannn Sevenannn mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sevenannn @phillipleblanc