Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Don't attach empty SQLite attachments #52

Merged
merged 3 commits into from
Aug 19, 2024
Merged

fix: Don't attach empty SQLite attachments #52

merged 3 commits into from
Aug 19, 2024
+88 −41

Conversation

peasee
Copy link
Collaborator

@peasee peasee commented Aug 19, 2024

🗣 Description

  • Fixes SQLite database attachments to avoid attempting to attach when an empty vec of attachments is supplied.
  • Updates tests to use randomised DB filenames to make new tests easier to add without clashing filenames.

@peasee peasee changed the title fix: Don't attach empty attachments fix: Don't attach empty SQLite attachments Aug 19, 2024
phillipleblanc
phillipleblanc approved these changes Aug 19, 2024
View reviewed changes
src/sql/db_connection_pool/sqlitepool.rs Outdated Show resolved Hide resolved
@y-f-u y-f-u merged commit 221a423 into datafusion-contrib:main Aug 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peasee @phillipleblanc @y-f-u