Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for ATTACHing SQLite databases together #42

Merged

Conversation

peasee
Copy link
Collaborator

@peasee peasee commented Aug 14, 2024

🗣 Description

  • Moves SqliteConnectionPool creation into a factory, to make the setup call and await stack cleaner.
  • Removes the ability to set factory parameter option keys in SqliteTableProviderFactory. Option keys are now set permanently.
  • SqliteConnectionPoolFactory also now decides the push down strategy, based on the existence of attached databases or database mode.
  • Adds support for attaching multiple SQLite databases together, for future federation support. These changes should permit querying any table for federation across any SQLite reader connection.

@peasee peasee marked this pull request as draft August 14, 2024 07:48
@peasee peasee marked this pull request as ready for review August 14, 2024 22:22
@peasee peasee marked this pull request as draft August 15, 2024 00:48
@peasee peasee marked this pull request as ready for review August 15, 2024 02:08
@phillipleblanc phillipleblanc merged commit c0d17ac into datafusion-contrib:main Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants