Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support interval type in arrow and postgres #39

Merged
merged 6 commits into from
Aug 15, 2024
Merged

Support interval type in arrow and postgres #39

merged 6 commits into from
Aug 15, 2024
+185 −13

Conversation

Sevenannn
Copy link
Contributor

@Sevenannn Sevenannn commented Aug 13, 2024 •
edited
Loading

- NOTE: Pending on integration test merge #38

  • Support interval types in arrow and postgres
  • Create new type IntervalFromSql to parse from raw postgres row to Rust native types
  • Unit tests added for testing the functionality of IntervalFromSql

@Sevenannn Sevenannn marked this pull request as ready for review August 13, 2024 22:54
@Sevenannn Sevenannn requested a review from y-f-u August 13, 2024 23:41
phillipleblanc
phillipleblanc approved these changes Aug 15, 2024
View reviewed changes
src/sql/arrow_sql_gen/statement.rs Outdated Show resolved Hide resolved
@phillipleblanc
Copy link
Collaborator

@Sevenannn please merge with main and I'll merge this PR

@phillipleblanc phillipleblanc merged commit 6c96072 into datafusion-contrib:main Aug 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phillipleblanc phillipleblanc phillipleblanc approved these changes

@y-f-u y-f-u Awaiting requested review from y-f-u

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sevenannn @phillipleblanc @y-f-u