feat: Stream SQLite writes #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipleblanc
approved these changes
Aug 1, 2024
sgrebnov
reviewed
Aug 1, 2024
| for batch in data_batches { | ||
| if batch.num_rows() > 0 { | ||
| sqlite.insert_batch(&transaction, batch, on_conflict.as_ref())?; | ||
| while let Some(data_batch) = batch_rx.blocking_recv() { |
There was a problem hiding this comment.
@peasee - can we perform a read query while streaming results (refreshing)? I have a concern that we can lock table for quite some time
There was a problem hiding this comment.
You can perform read queries for tables except the ones still accelerating. If you try querying a table that's accelerating, the query will hang until the acceleration finishes before returning values.
This is the existing behavior on main.
|
This is different as we previously collected all data first and was writing only after that thus less locking time
Thanks,
Sergey
________________________________
From: peasee ***@***.***>
Sent: Wednesday, July 31, 2024 7:22:46 PM
To: datafusion-contrib/datafusion-table-providers ***@***.***>
Cc: Sergei Grebnov ***@***.***>; Comment ***@***.***>
Subject: Re: [datafusion-contrib/datafusion-table-providers] feat: Stream SQLite writes (PR #24)
@peasee commented on this pull request.
________________________________
In src/sqlite/write.rs<#24 (comment)>:
@@ -156,9 +158,9 @@ impl DataSink for SqliteDataSink {
sqlite.delete_all_table_data(&transaction)?;
}
- for batch in data_batches {
- if batch.num_rows() > 0 {
- sqlite.insert_batch(&transaction, batch, on_conflict.as_ref())?;
+ while let Some(data_batch) = batch_rx.blocking_recv() {
You can perform read queries for tables except the ones still accelerating. If you try querying a table that's accelerating, the query will hang until the acceleration finishes before returning values.
This is the existing behavior on main.
—
Reply to this email directly, view it on GitHub<#24 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHPUTG2BR47UO2YR5OX2VLZPGLXNAVCNFSM6AAAAABLZQUS5WVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEMJRGQZTSNZXGE>.
You are receiving this because you commented.Message ID: ***@***.***>
|
Sevenannn
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
Through some manual testing, this improves both write performance (by 20-40%) and memory usage (by 80+%) during write operations with 60 million row tables.