Rebase spiceai onto main branch #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* wip * duckdb streaming * clippy * arrow to arrow stream * error message * fix: Support `INTERVAL` in SQLite (datafusion-contrib#85) * poc: Support interval in SQLite using an AST analyzer * Refactoring * u64 -> i64 * fix: Support INTERVAL expressions in SQLite * docs: Add comment about flattening arguments list * refactor: Rename SQLiteVisitor to SQLiteIntervalVisitor * test: Add some tests --------- Co-authored-by: Phillip LeBlanc <[email protected]> * Use DuckDB streaming * Fixes * Fix feature flagging * Fix lint * Add spiceai branch to pull_request --------- Co-authored-by: peasee <[email protected]> Co-authored-by: Phillip LeBlanc <[email protected]>
…fusion-contrib#88) * SQLite: Validate expected indexes when attaching local datasets * Add test for indexes creation and retrieval (SQLite) * Update warning messages
* fix: Don't silence blocking task errors * fix: Cover Ok(Err()) match arm for DuckDB writer handle * refactor: Rename overloaded error e
* fix: Re-attach databases on each query * Update src/sql/db_connection_pool/dbconnection/duckdbconn.rs --------- Co-authored-by: Phillip LeBlanc <[email protected]>
…ontrib#96) * Correctly handle mysql timestamp() and datetime() types * Restructure MySQL test, add test for timestamp() types * Include test for datetime types
* Postgres enum support * Add enum test as part of integration test * update * Remove the duplicate function * fix --------- Co-authored-by: Phillip LeBlanc <[email protected]>
phillipleblanc
approved these changes
Sep 19, 2024
Cargo.toml
Outdated
| postgres-federation = ["postgres"] | ||
|
|
||
| [patch.crates-io] | ||
| duckdb = { git = "https://github.com/spiceai/duckdb-rs.git", rev = "f2ca47d094a5636df8b9f3792b2f474a7b210dc1" } |
There was a problem hiding this comment.
I was not able to replace this with the crate version.
We should keep this PR open, and upstream the changes from spiceai/duckdb-rs to duckdb. what do you think?
The issue is coming from this line
There was a problem hiding this comment.
Yeah, we've had the PR open for a while now. duckdb/duckdb-rs#373
…n-contrib#109) * wip * wip * wip * tweak
* Support all time() types in MySQL * Include test for time types
…ol (datafusion-contrib#113) * Verify MySQL parameters and connections before creating connection pool * Update
Merged
…L_TYPE_STRING types (datafusion-contrib#118)
…on-contrib#121) * Add sqlite_busytimeout parameter as user configurable param * Remove debug log * Fix lint, fix integration test --------- Co-authored-by: Phillip LeBlanc <[email protected]>
phillipleblanc
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.