-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and package organization. #52
Conversation
…dencies. Update recommended Docker container. Make GroupedMLP tests conditional on package availability.
'stanford-stk @ git+https://github.com/stanford-futuredata/stk.git@main', | ||
'grouped_gemm @ git+https://github.com/tgale96/grouped_gemm@main', | ||
'mosaicml-turbo==0.0.4', | ||
"triton==2.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this need strict pin? Might cause problems down the road if someone else (eg torch) starts upgrading....
Could we lower bound?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned about Triton breaking us with a newer release. We could make it >=2.1.0, but that's a little risky.
setup.py
Outdated
extra_deps['dev'] = [ | ||
'absl-py', | ||
extra_deps["gg"] = [ | ||
"grouped_gemm @ git+https://github.com/tgale96/grouped_gemm@main", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should use a tagged version instead of main branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm moving this package onto PyPi so we can push the new megablocks packages.
] | ||
|
||
extra_deps["quant"] = [ | ||
"mosaicml-turbo==0.0.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"mosaicml-turbo==0.0.4", | |
"mosaicml-turbo==0.0.5", |
@dblalock can we bump to 0.0.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets do this in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, I'd rather not touch anything right now
No description provided.