Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and package organization. #52

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

tgale96
Copy link
Contributor

@tgale96 tgale96 commented Dec 11, 2023

No description provided.

…dencies. Update recommended Docker container. Make GroupedMLP tests conditional on package availability.
'stanford-stk @ git+https://github.com/stanford-futuredata/stk.git@main',
'grouped_gemm @ git+https://github.com/tgale96/grouped_gemm@main',
'mosaicml-turbo==0.0.4',
"triton==2.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need strict pin? Might cause problems down the road if someone else (eg torch) starts upgrading....

Could we lower bound?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about Triton breaking us with a newer release. We could make it >=2.1.0, but that's a little risky.

setup.py Outdated
extra_deps['dev'] = [
'absl-py',
extra_deps["gg"] = [
"grouped_gemm @ git+https://github.com/tgale96/grouped_gemm@main",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a tagged version instead of main branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm moving this package onto PyPi so we can push the new megablocks packages.

]

extra_deps["quant"] = [
"mosaicml-turbo==0.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mosaicml-turbo==0.0.4",
"mosaicml-turbo==0.0.5",

@dblalock can we bump to 0.0.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this in a separate PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I'd rather not touch anything right now

@tgale96 tgale96 merged commit 409686e into main Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants