Merge pull request #81 from dailymotion-oss/apiVersion-osiris-admissi…

…onregistration Osiris apiVersion update
dailymotion-oss · Mar 8, 2022 · 3d3b3b9 · 3d3b3b9
2 parents f7acb91 + 963d4b0
commit 3d3b3b9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 3 deletions.
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
@@ -1,2 +1,8 @@
 # https://help.github.com/en/articles/about-code-owners
-* @vbehar
+* @anthony-pastor
+* @cyril-corbon
+* @yosri-daily
+* @JordanGoasdoue
+* @raphael-messner
+* @alextriquet
+* @Bencyril
diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml
@@ -43,3 +43,4 @@ jobs:
         uses: golangci/golangci-lint-action@v2
         with:
           version: v1.37
+          args: --timeout=5m
diff --git a/charts/osiris/templates/endpoints-hijacker-webhook-config.yaml b/charts/osiris/templates/endpoints-hijacker-webhook-config.yaml
@@ -18,7 +18,7 @@ data:
   tls.crt: {{ b64enc $cert.Cert }}
   tls.key: {{ b64enc $cert.Key }}
 ---
-apiVersion: admissionregistration.k8s.io/v1beta1
+apiVersion: admissionregistration.k8s.io/v1
 kind: MutatingWebhookConfiguration
 metadata:
   name: {{ include "osiris.fullname" . }}-endpoints-hijacker
@@ -46,3 +46,5 @@ webhooks:
     - CREATE
     - UPDATE
   failurePolicy: Ignore
+  sideEffects: None
+  admissionReviewVersions: ["v1", "v1beta1"]
diff --git a/charts/osiris/templates/proxy-injector-webhook-config.yaml b/charts/osiris/templates/proxy-injector-webhook-config.yaml
@@ -18,7 +18,7 @@ data:
   tls.crt: {{ b64enc $cert.Cert }}
   tls.key: {{ b64enc $cert.Key }}
 ---
-apiVersion: admissionregistration.k8s.io/v1beta1
+apiVersion: admissionregistration.k8s.io/v1
 kind: MutatingWebhookConfiguration
 metadata:
   name: {{ include "osiris.fullname" . }}-proxy-injector
@@ -45,3 +45,5 @@ webhooks:
     operations:
     - CREATE
   failurePolicy: Ignore
+  sideEffects: None
+  admissionReviewVersions: ["v1", "v1beta1"]