stop using python semver parsing for mysql versions #11868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
prha
force-pushed
the
prha/mysql_version_parsing
branch
from
b44f4ca to
7b14016
Compare
alangenfeld
approved these changes
Jan 27, 2023
| @@ -46,6 +47,26 @@ def get_conn_string(username, password, hostname, db_name, port="3306"): | |||
| ) | |||
|
|
|||
|
|
|||
| def parse_mysql_version(version: str) -> tuple: | |||
There was a problem hiding this comment.
add some test cases that use this directly too
prha
force-pushed
the
prha/mysql_version_parsing
branch
from
ec32b6a to
d85600f
Compare
gibsondan
pushed a commit
that referenced
this pull request
Jan 27, 2023
### Summary & Motivation We were using `packaging.parse` to compare mysql server versions, which broke when `0.23.0` was released with dropped support for `LegacyVersion`. This rolls our own custom version compares to find minimum supported versions, which is tolerant of non semver compliant version strings. The regex parses all the numeric values, and does tuple int comparisons. Reported in #11794 Reference links: pypa/packaging#407 ### How I Tested These Changes Added some test cases that override the server version string to exercise the parsing logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
We were using
packaging.parseto compare mysql server versions, which broke when0.23.0was released with dropped support forLegacyVersion.This rolls our own custom version compares to find minimum supported versions, which is tolerant of non semver compliant version strings.
The regex parses all the numeric values, and does tuple int comparisons.
Reported in #11794
Reference links:
pypa/packaging#407
How I Tested These Changes
Added some test cases that override the server version string to exercise the parsing logic.