Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Access-Control-Allow-Credentials be true by default? #95

Closed
JakobKallin opened this issue Sep 25, 2015 · 1 comment
Closed

Should Access-Control-Allow-Credentials be true by default? #95

JakobKallin opened this issue Sep 25, 2015 · 1 comment

Comments

@JakobKallin
Copy link

The default value for the credentials parameter is true, causing Access-Control-Allow-Credentials to be set to true. Should this really be the default? It seems to me that the purpose of the header is to require explicit opt-in (for developers who don't know about it or forget to consider it), but Rack CORS makes it opt-out instead.

@badnorseman
Copy link

Perhaps it would be a good idea to link to https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS#Access-Control-Allow-Credentials in documentation. It explains that origins * wouldn't work with credentials true.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants