Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update action checkout from v1 to v2 (avoids possible race issue) #421

Merged
merged 1 commit into from
Mar 12, 2020

Conversation

kinow
Copy link
Member

@kinow kinow commented Mar 10, 2020

This is a small change with no associated Issue.

Was going to checkout another branch when I noticed I had changes from yesterday. I was going to update actions to see if coverage was working again for PR's, but in the end didn't need to update anything (#328).

But had already updated the checkout action, and today I remembered v1 had an issue where if you push too many changes, the PR may get stuck without being able to check out the code. They fixed it in the v2, so it should be a good idea to update it.

One review should do. Best way to review is just wait for GitHub actions to run, and confirm it checked out the code with no issues.

Requirements check-list

  • I have read CONTRIBUTING.md and added my name as a Code Contributor.
  • Contains logically grouped changes (else tidy your branch by rebase).
  • Does not contain off-topic changes (use other PRs for other changes).
  • Does not need tests (why? CI only).
  • No change log entry required (why? e.g. invisible to users).
  • No documentation update required.

@kinow kinow added this to the 0.2 milestone Mar 10, 2020
@kinow kinow self-assigned this Mar 10, 2020
@hjoliver hjoliver merged commit daaae07 into cylc:master Mar 12, 2020
@kinow kinow deleted the update-checkout-action branch March 19, 2020 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants