Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading animated documents from the command line #58

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

cwensley
Copy link
Owner

  • Only dispose of the loading stream after the document is loaded as it can be used during animation
  • Ensure CanSeek/CanRead are propagated for BaudStream and SauceStream
  • Don't try to create the out directory if the out file does not contain a path when converting
    Fixes 3.3.0-beta1 CWD/path issues when fed file from CLI #57

- Only dispose of the loading stream after the document is loaded as it can be used during animation
- Ensure CanSeek/CanRead are propagated for BaudStream and SauceStream
- Don't try to create the out directory if the out file does not contain a path when converting
Fixes #57
@cwensley cwensley added this to the 3.3.0 milestone Sep 14, 2022
@cwensley cwensley added the bug label Sep 14, 2022
@cwensley cwensley merged commit 7271073 into main Sep 14, 2022
@cwensley cwensley deleted the fix-loading-animated-from-command-line branch September 14, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3.3.0-beta1 CWD/path issues when fed file from CLI
1 participant