Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/misc #9

Closed
wants to merge 4 commits into from
Closed

Fix/misc #9

wants to merge 4 commits into from

Conversation

BeckyPollard
Copy link

RE: Website needs love

Summary of changes:

(see attached image for changes preview)

Style changes via CSS.

  • Styling: Add colour variables for the big three red, navy, blue.
  • Header: Fix alignment of buttons.
  • Code samples: Headers of sections are now bold to contrast paragraph copy.
  • Code samples: Add section breaks for examples for easier reading.
  • Accessibility: Hamburger menu is now accessible through tabbing.
  • Accessibility: Links have hover and focus styles.
  • Accessibility: Icons that are links have hover and focus styles.
CHANGES BEFORE
Screen Shot 2021-10-29 at 5 40 37 PM Screen Shot 2021-10-29 at 5 40 41 PM
Screen Shot 2021-10-29 at 5 41 32 PM Screen Shot 2021-10-29 at 5 41 36 PM

ezgif-1-86f1d72a6377

Notes for PR

  • CSS? SCSS?

Feedback, nitpicks, and/or corrections encouraged! banana

@BeckyPollard BeckyPollard requested a review from evert October 29, 2021 21:51
@evert
Copy link
Member

evert commented Oct 29, 2021 •
edited
Loading

Looks great! Did you forget to commit the sass version ? I think we just need to commit both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evert evert Awaiting requested review from evert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeckyPollard @evert