Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin] Deprecate TestRunFinished(Instant) #2169

Merged
merged 1 commit into from
Oct 31, 2020

Conversation

mpkorstanje
Copy link
Contributor

Since v6 the TestRunFinished event always contains a result when emitted by
Cucumber.

Since v6 the `TestRunFinished` event always contains a result when emitted by
Cucumber.
@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #2169 into main will increase coverage by 0.01%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2169      +/-   ##
============================================
+ Coverage     82.78%   82.79%   +0.01%     
  Complexity     2313     2313              
============================================
  Files           306      306              
  Lines          8293     8295       +2     
  Branches        767      767              
============================================
+ Hits           6865     6868       +3     
+ Misses         1119     1118       -1     
  Partials        309      309              
Impacted Files Coverage Δ Complexity Δ
...java/io/cucumber/plugin/event/TestRunFinished.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...in/java/io/cucumber/core/plugin/PluginFactory.java 74.46% <100.00%> (+2.42%) 25.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f8e1eb2...f035531. Read the comment docs.

@mpkorstanje mpkorstanje merged commit 814f04b into main Oct 31, 2020
@mpkorstanje mpkorstanje deleted the deprecate-test-run-finished-instant-constructor branch October 31, 2020 14:14
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant