[Core] Improve error message when plugin paths collide #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cucumber v6 introduced a new html formatter. This formatter writes to a file rather then a directory[1]. However a typical use to ensure all files and up in a single folder would be `plugin=json:target/cucumber/report.json, html:target/cucumber`. So depending on the order this results in Cucumber being unable to either create the `target/cucumber` as file for the html report or `target/cucumber` as a directory for the json report. The improved error message should point this out. Fixes: #2108 Additionally the PluginFactory tests were rewritten to make them follow the arrange-act-test pattern. 1. https://github.com/cucumber/cucumber-jvm/blob/main/release-notes/v6.0.0.md#improved-html-formatter
Codecov Report
@@ Coverage Diff @@
## main #2168 +/- ##
============================================
+ Coverage 82.78% 82.80% +0.02%
Complexity 2313 2313
============================================
Files 306 306
Lines 8293 8294 +1
Branches 767 767
============================================
+ Hits 6865 6868 +3
+ Misses 1119 1117 -2
Partials 309 309
Continue to review full report at Codecov.
|
This was referenced Mar 15, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cucumber v6 introduced a new html formatter. This formatter writes to a file
rather then a directory[1]. However a typical use to ensure all files and up
in a single folder would be
plugin=json:target/cucumber/report.json, html:target/cucumber.So depending on the order this results in Cucumber being unable to either
create the
target/cucumberas file for the html report ortarget/cucumberas a directory for the json report.
The improved error message should point this out.
Fixes: #2108
Additionally the PluginFactory tests were rewritten to make them follow the
arrange-act-test pattern.