Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing type definition for @sinon/fake-timers #2141

Closed
christian-bromann opened this issue Sep 20, 2022 · 2 comments · Fixed by #2142
Closed

Missing type definition for @sinon/fake-timers #2141

christian-bromann opened this issue Sep 20, 2022 · 2 comments · Fixed by #2142
Assignees
Labels
🐛 bug Defect / Bug ✅ accepted The core team has agreed that it is a good idea to fix this

Comments

@christian-bromann
Copy link

👓 What did you see?

This commit introduces type usage from @sinonjs/fake-timers however these types are defined as devDependencies. This causes 3rd party users like WebdriverIO to fail due to Could not find a declaration file for module '@sinonjs/fake-timers'.

✅ What did you expect to see?

Have @types/sinonjs__fake-timers as dependency now given their types are used and exposed.

📦 Which tool/library version are you using?

Latest CucumberJS

🔬 How could we reproduce it?

n/a

📚 Any additional context?

See failing builds for WebdriverIO: https://github.com/webdriverio/webdriverio/actions/runs/3090504859/jobs/4999391609


This text was originally generated from a template, then edited by hand. You can modify the template here.

christian-bromann added a commit to webdriverio/webdriverio that referenced this issue Sep 20, 2022
@davidjgoss
Copy link
Contributor

Thanks for raising @christian-bromann, will get something out for this shortly.

@davidjgoss davidjgoss self-assigned this Sep 20, 2022
@davidjgoss davidjgoss added 🐛 bug Defect / Bug ✅ accepted The core team has agreed that it is a good idea to fix this labels Sep 20, 2022
@davidjgoss
Copy link
Contributor

I reworked this to avoid relying on the sinon types which should resolve the issue. Published 8.6.0 including this - let me know if that does the trick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Defect / Bug ✅ accepted The core team has agreed that it is a good idea to fix this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants