Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bad transition fix when reducing d3 size #953

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Conversation

ptbrowne
Copy link
Contributor

@ptbrowne ptbrowne commented Feb 27, 2019

When changing the code not to bring the whole d3 but only some methods, I had an error transition() is not a function. I made a mistake when fixing it, I thought I needed to wrap the d3-selection into a transition. This was unnecessary since merely importing d3-transition adds the transition method to d3-selections. d3-transition is imported in utils/d3.

@ptbrowne ptbrowne merged commit fda42f1 into master Feb 27, 2019
@ptbrowne ptbrowne deleted the fix-d3-transition branch February 27, 2019 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants