Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appendix-a.md #1190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update appendix-a.md #1190

wants to merge 1 commit into from

Conversation

crStiv
Copy link

@crStiv crStiv commented Jan 2, 2025

Proposed changes:

  • Added the enum ConnectionState for typing connection states.
  • Included JSDoc documentation for the connOpenInit function.
  • Replaced let/var with const for immutable variables.
  • Substituted string literals with enum values.

These changes will improve:

  • Type safety of the code.
  • Readability and maintainability.
  • Documentation clarity.
  • Prevention of errors due to typos in string states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@angbrav angbrav Awaiting requested review from angbrav angbrav is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@crStiv