Support cross-region SNS topic subscription #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaorimatz
force-pushed
the
support-cross-region-sns-topic-subscription
branch
from
9d90b0e to
d87ddde
Compare
|
Please let me know if you think I should take another option (or this request is not acceptable in the first place 😂 ). |
|
cc @cookpad/dev-infra |
eagletmt
reviewed
Jul 11, 2018
| @@ -44,6 +46,12 @@ def destroy | |||
| private | |||
|
|
|||
| def fetch_sns_topic_arns | |||
| Barbeque::SNSSubscriptionService.sns_client.list_topics.topics.map(&:topic_arn) | |||
| if Barbeque.config.sns_regions.empty? | |||
| Aws::SNS::Client.new.list_topics.topics.map(&:topic_arn) | |||
There was a problem hiding this comment.
Aws::SNS::Clinet should be memoized because Aws::SNS::Client.new retrieves credentials each time when ECS task role or EC2 instance profile is available.
There was a problem hiding this comment.
2a14998 (revised commit comment 💦 )
| @@ -7,5 +7,9 @@ class SNSSubscription < ApplicationRecord | |||
| validates :topic_arn, | |||
| uniqueness: { scope: :job_queue, message: 'should be set with only one queue' }, | |||
| presence: true | |||
|
|
|||
| def region | |||
| /\Aarn:aws:sns:([a-z0-9-]+):/.match(topic_arn)[1] | |||
There was a problem hiding this comment.
(nit) /\Aarn:aws:sns:([a-z0-9-]+):/.slice(topic_arn, 1)
eagletmt
approved these changes
Jul 11, 2018
kaorimatz
force-pushed
the
support-cross-region-sns-topic-subscription
branch
from
06d3a6c to
2a14998
Compare
|
FYI conflicted ;) |
kaorimatz
force-pushed
the
support-cross-region-sns-topic-subscription
branch
from
2a14998 to
f581ea6
Compare
|
Thanks, rebased ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to support subscribing a topic in a different region from the SQS queue.
I came up with a few options:
This is an implementation of the third option, which involves no change in UI.