Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "could not be converted to string" on normal use case. #2

Closed
wants to merge 1 commit into from

Conversation

andrewevansmith
Copy link

The magic getter was trying to get the content under $field->{en-US} using an object instead of the locale code.

Had to patch this to get a simple blog post to display it's title properly.

@realityking
Copy link
Contributor

Thank you for the pull request. First of all sorry for taking so long to get to this, I didn't check github over the holidays.

The issue is with fields that are not localized (which I annoyingly hadn't tested). Unfortunately your fix would have broken localized fields. I fixed the issue in a different way and added unit tests to ensure it doesn't happen again.

I'll cut a new release either this week or next week.

@andrewevansmith
Copy link
Author

Thanks! :)

On Wed, Jan 6, 2016 at 11:08 AM, Rouven Weßling [email protected]
wrote:

Thank you for the pull request. First of all sorry for taking so long to
get to this, I didn't check github over the holidays.

The issue is with fields that are not localized (which I annoyingly hadn't
tested). Unfortunately your fix would have broken localized fields. I fixed
the issue in a different way
538a3df#diff-883aa58f6a6c5727f30e5947d6d077ecL91
and added unit tests to ensure it doesn't happen again.

I'll cut a new release either this week or next week.


Reply to this email directly or view it on GitHub
#2 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants