libnetwork/netavark: add isolate option 'strict' #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassi-github
force-pushed
the
netavark-strict-isolation
branch
from
accde5a to
55f56c1
Compare
yassi-github
force-pushed
the
netavark-strict-isolation
branch
from
55f56c1 to
1979b54
Compare
|
@Luap99 PTAL |
|
@vrothberg PTAL |
vrothberg
reviewed
Jun 20, 2023
May i add |
|
Yes, |
The strict isolate refuses to communicate with non-isolate and isolate. Signed-off-by: Saigusa Yasushi <[email protected]>
yassi-github
force-pushed
the
netavark-strict-isolation
branch
from
1979b54 to
238885e
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99, vrothberg, yassi-github The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isolation is only enabled when both bridges are in
--opt isolate=truemode.This means it is possible to communicate with non-isolated and isolated.
So we adds
--opt isolate=strictoption to deny communication, even with non-isolated and isolated.Passing this option to netavark creates iptables rules for strict isolation.