-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add big-fat-warning re: golang 1.21+ toolchain #187
Conversation
Updating to the latest config. linter reformats the entire config file. Incorporate the new format, with some minor adjustments to comments. No settings are actually changed here. It's all cosmetic and formatting. Signed-off-by: Chris Evich <[email protected]>
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's e16a5c5e8a0ecd89c85279fd48ee88265f9bfb4c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t know that I have any specific expertise here — I agree with the intent, and the mechanism of all the changes looks plausible (but I didn’t, so far, validate them line by line against Renovate’s documentation).
LGTM I guess?
Ref. upstream discussion: golang/go#65847 |
This prevents running into docker-hub rate limits Signed-off-by: Chris Evich <[email protected]>
Signed-off-by: Chris Evich <[email protected]>
Successfully triggered github-actions/success task to indicate successful run of cirrus-ci_retrospective integration and unit testing from this PR's 36c2bc68e9f72ad11d3cf23d6895b8d640c9ab41. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
Thanks guys, merging. |
For the record, later we found at https://go.dev/ref/mod :
So dependency updates should, most of the time, not trigger a |
Also to confirm this change seem to work: containers/common#1915 It no longer bumps go+add toolchain there, however our newer version in f39 does that and therefore the make vendor check is failing which is what we want for now I guess. |
In addition to some much needed config. file maintenance:
/cc @mtrmac