Quick bug fixes #54
Merged
Quick bug fixes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The `ignore_run_exports` transformation was completely bugged and was conditionalized on the wrong path - Adds the missing `run_constrained` -> `run_constraints` transformation
- Bumps integration testing metrics - Fixes an issue where the integration tests may silently fail to meet the testing threshold. The `pipefail` shell option was not enabled, causing `tee` to always return `0`
beeankha
reviewed
May 7, 2024
Comment on lines
+204
to
+206
| # "If I had a nickel for every time `skip` was misspelled, I would have several nickels. Which isn't a lot, but | ||
| # it is weird that it has happened multiple times." | ||
| # - Dr. Doofenshmirtz, probably |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few quick bug fixes I found and fixed today.
Also includes some minor spelling corrections that happen on occasion. They don't happen a lot but it's weird they happen more than once.
Also fixes an issue where the integration tests may silently fail to meet the testing threshold. The
pipefailshell option was not enabled, causingteeto always return0