-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add windows build #25
Add windows build #25
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge-admin, please rerender |
04fdc32
to
a0d0ffb
Compare
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
9927e4b
to
e30162f
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally. This message was generated by GitHub actions workflow run https://github.com/conda-forge/llvm-spirv-feedstock/actions/runs/9390901726. |
…nda-forge-pinning 2024.06.05.08.51.24
e30162f
to
eb69290
Compare
- include/LLVMSPIRVLib/ | ||
- lib/libLLVMSPIRVLib.dylib # [osx] | ||
- lib/libLLVMSPIRVLib.so # [linux] | ||
- {{ library }}lib/LLVMSPIRVLib.lib # [win] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no DLL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isuruf unfortunately, no. LLVM does not support shared libraries on windows:
https://www.llvm.org/docs/CMake.html#llvm-related-variables
https://github.com/KhronosGroup/SPIRV-LLVM-Translator/blob/main/lib/SPIRV/CMakeLists.txt#L43
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, if you know any workarounds - I would appreciate. I've tried clangxx
- it did not work (it may be due to msvc linker). The only other option could be to use m2gw64
, but it will bring it's own runtime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.lib
is only dev package dependency (libllvmspirv
) and is not presented at the llvm-spirv
packages.
@isuruf @matthiasdiener could you take a look on the PR if you are okay with the changes? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
a9fbe6f
to
1f0d306
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Add windows build of the binary. Library is built as a static library and there is no
libllvmspirv18
for windows cause there is no support for static library build for windows from the upstream project.