Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows build #25

Merged
merged 3 commits into from
Jun 13, 2024
Merged

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Jun 5, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Add windows build of the binary. Library is built as a static library and there is no libllvmspirv18 for windows cause there is no support for static library build for windows from the upstream project.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Jun 5, 2024

@conda-forge-admin, please rerender

@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_windows_build branch from 04fdc32 to a0d0ffb Compare June 5, 2024 16:42
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ZzEeKkAa ZzEeKkAa mentioned this pull request Jun 5, 2024
3 tasks
@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_windows_build branch 2 times, most recently from 9927e4b to e30162f Compare June 5, 2024 20:36
@ZzEeKkAa
Copy link
Contributor Author

ZzEeKkAa commented Jun 5, 2024

@conda-forge-admin, please rerender

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you but ran into some issues. Please check the output logs of the latest webservices GitHub actions workflow run for errors. You can also ping conda-forge/core for further assistance or you can try rerendeing locally.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/llvm-spirv-feedstock/actions/runs/9390901726.

@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_windows_build branch from e30162f to eb69290 Compare June 5, 2024 21:04
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review June 5, 2024 21:05
- include/LLVMSPIRVLib/
- lib/libLLVMSPIRVLib.dylib # [osx]
- lib/libLLVMSPIRVLib.so # [linux]
- {{ library }}lib/LLVMSPIRVLib.lib # [win]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no DLL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@ZzEeKkAa ZzEeKkAa Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, if you know any workarounds - I would appreciate. I've tried clangxx - it did not work (it may be due to msvc linker). The only other option could be to use m2gw64, but it will bring it's own runtime.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.lib is only dev package dependency (libllvmspirv) and is not presented at the llvm-spirv packages.

@ZzEeKkAa
Copy link
Contributor Author

@isuruf @matthiasdiener could you take a look on the PR if you are okay with the changes?

recipe/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [79]

@ZzEeKkAa ZzEeKkAa force-pushed the feature/add_windows_build branch from a9fbe6f to 1f0d306 Compare June 11, 2024 16:06
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@ZzEeKkAa ZzEeKkAa requested a review from isuruf June 11, 2024 16:07
@ZzEeKkAa ZzEeKkAa merged commit 4b00439 into conda-forge:main Jun 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants