-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cmake installation #84
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
…nda-forge-pinning 2022.08.04.07.32.40
cmake |
Thanks for this contribution @mwittgen! How did you generate this file? Since it looks a bit different from the example in the thread you linked to, have you checked that it works like this? Is it also possible to dynamically generate the file in the recipe? That way we don't have to maintain this file. It would be nice to have a simple test if it works; just a build against the installed FFTW3, using CMake for configuration. That would also catch situations when it needs to be updated. If you don't have time for that, I'm okay with merging anyway, since I don't think it will hurt either way to add this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments above.
The file was generated by obtaining the tarball and doing a full cmake/make install. |
That would be great! If you have time, of course. If not, then I would vote to merge anyway so that people can try it out. Do other reviewers have another opinion on this? |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
I implemented generating the cmake file from source and added a small cmake test to build and link. |
This is perfect, thanks a lot for this excellent contribution! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)