Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First stab at contributing guide #1427

Merged
merged 2 commits into from
Jun 25, 2021
Merged

First stab at contributing guide #1427

merged 2 commits into from
Jun 25, 2021

Conversation

maltenuhn
Copy link
Member

A start at some docs, mainly pulled from my chat log with Omar and focused on how our editor-state and redux architecture works (since almost all UI-level changes will probably need to touch that). It's very basic but probably better than typing this up (and losing it) in Discord

@github-actions
Copy link
Contributor

Link to test editor
Scroll Canvas: 31.3ms (24.5-41.2ms) | Resize: 57.7ms (11.1-168ms) | Selection: 219.5ms (185.8-623.7ms) | Calc Pi: 29ms (28-34ms) | Empty Dispatch: 36.2ms (33.8-109.8ms) | (Chart)

@Rheeseyb
Copy link
Contributor

We already have https://github.com/concrete-utopia/utopia/blob/master/contributing.md - is it worth appending this to the end of that? Or alternatively starting an effort to document everything under docs/ and move the above file there?

@maltenuhn
Copy link
Member Author

@Rheeseyb I didn't realise! On reading it, it seems to be mainly about rules to comply with. /docs seems like the right place (or github pages?)

@github-actions
Copy link
Contributor

Link to test editor
Scroll Canvas: 33ms (24.8-65.5ms) | Resize: 60.7ms (15.6-423.2ms) | Selection: 266.5ms (208.2-576.5ms) | Calc Pi: 34ms (31-49ms) | Empty Dispatch: 38ms (33.4-134.6ms) | (Chart)

@maltenuhn
Copy link
Member Author

All right, I've moved this to docs. I hope it's juicy enough to attract a roving Docusaurus or two...

@maltenuhn maltenuhn merged commit e3efe95 into master Jun 25, 2021
@maltenuhn maltenuhn deleted the docs/contributing-101 branch June 25, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants