Correct the parsing of hsl colours. #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #1216. - When invoking the `Chroma.hsl` function, reduce the saturation and lightness values down to the range `[0..1]`.
|
Link to test editor |
Rheeseyb
approved these changes
Jun 22, 2021
enidemi
approved these changes
Jun 23, 2021
| @@ -2055,7 +2055,7 @@ export function cssColorToChromaColor(c: CSSColor): Either<string, Chroma.Color> | |||
| } else if (isHex(c)) { | |||
| return right(Chroma.hex(c.hex)) | |||
| } else if (isHSL(c)) { | |||
| return right((Chroma.hsl as any)(c.h, c.s, c.l, c.a)) | |||
| return right((Chroma.hsl as any)(c.h, c.s / 100.0, c.l / 100.0, c.a)) | |||
There was a problem hiding this comment.
is this c.s / 100.0 different from c.s / 100 in javascript?
There was a problem hiding this comment.
I don't believe so, they're apparently equal, it just seemed like the right thing to do given that it's going to be double-like.
balazsbajorics
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1216
Problem:
Previously when parsing
hsl(...)colours, the wrong range was used when invoking the conversion function in Chroma.Fix:
Reduced the range of saturation and lightness values when passing them to Chroma.
Commit Details:
Chroma.hslfunction, reduce the saturationand lightness values down to the range
[0..1].