Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply maybeUnixPath to ssh path in build config #723

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

Vigilans
Copy link
Contributor

According to build ssh config's document:

ssh property syntax can be either:

default: Let the builder connect to the SSH-agent.
ID=path: A key/value definition of an ID and the associated path. It can be either a [PEM](https://en.wikipedia.org/wiki/Privacy-Enhanced_Mail) file, or path to ssh-agent socket.

Using a custom id myproject with path to a local SSH key:

build:
  context: .
  ssh:
    - myproject=~/.ssh/myproject.pem

SSH config's value type is the path to the key, therefore should be resolved with paths.ResolveRelativePaths.

@Vigilans Vigilans requested a review from ndeloof as a code owner December 22, 2024 05:13
@ndeloof ndeloof force-pushed the vigilans/ssh-path branch from 3ddd43e to 4bd8c32 Compare January 7, 2025 07:21
@ndeloof ndeloof enabled auto-merge (rebase) January 7, 2025 07:21
@ndeloof ndeloof merged commit 9642b85 into compose-spec:main Jan 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants