Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove System.Linq.Expressions dependency. #764

Merged
merged 1 commit into from
May 12, 2022
Merged

Remove System.Linq.Expressions dependency. #764

merged 1 commit into from
May 12, 2022

Conversation

NN---
Copy link
Contributor

@NN--- NN--- commented Jun 26, 2021

The code is much simpler and it allows porting library to older framework.
theraot/Theraot#157.

@NN--- NN--- force-pushed the remove_expression branch from b9e6a18 to 31895f1 Compare June 27, 2021 15:37
@NN---
Copy link
Contributor Author

NN--- commented Oct 27, 2021

@moh-hassan Any update ?

ericnewton76
ericnewton76 reviewed May 12, 2022
View reviewed changes
Copy link
Member

@ericnewton76 ericnewton76 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a SystemLinqExpressions nuget package that could be removed too?

nvm I see whats going on

ericnewton76
ericnewton76 approved these changes May 12, 2022
View reviewed changes
Copy link
Member

@ericnewton76 ericnewton76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change, but I cant readily see the impact the change will make. I'm a little worried about merging it but I think it'll work.

@ericnewton76 ericnewton76 merged commit af75319 into commandlineparser:develop May 12, 2022
@twpol twpol mentioned this pull request May 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericnewton76 ericnewton76 ericnewton76 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NN--- @ericnewton76