Fix syncing issues with ASB XMR wallet during startup #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 4398fa5)
pokkst
changed the title
|
Thanks for the PR. Seems sensible to me. Please fix the clippy errors (see the failed test) before we can get this merged. |
binarybaron
requested changes
Aug 13, 2023
|
Should we do this for the CLI as well? I'm not sure if the "swap-monitoring-wallet is recreated at each startup |
|
Any chance for a re-review? Thanks |
|
Me and delta1 both think we should save the wallet periodically instead of at certain states. (See the previous review) |
|
@binarybaron how should periodic saving be scheduled? On a regular cadence (every X minutes)? Or after triggered after events like transactions? Both? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been encountering an issue where the monero wallet for the ASB will properly sync upon startup, and can perform its usual tasks, but it does not save this state. This means that when restarting the ASB program, the balance will be that of from BEFORE the last startup and sync, sometimes going back until it was first created, essentially erasing all progress.
This adds https://www.getmonero.org/resources/developer-guides/wallet-rpc.html#store as a method for the RPC client, allowing the ASB program to save the wallet's state periodically.