Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Implement support for "CTL" processor. #977

Merged
merged 2 commits into from
May 18, 2022
Merged

PR: Implement support for "CTL" processor. #977

merged 2 commits into from
May 18, 2022

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented May 7, 2022 •
edited
Loading

Summary

This PR implements support for a CTL processor as described in #975.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Mypy static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • [NA] New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@KelSolaar KelSolaar requested review from nick-shaw and zachlewis May 7, 2022 23:24
@KelSolaar
Copy link
Member Author

@aforsythe and @scottdyer for VIS!

@KelSolaar KelSolaar force-pushed the feature/ctl_processor branch 2 times, most recently from 496aefe to abec73f Compare May 8, 2022 07:14
@coveralls
Copy link

coveralls commented May 8, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.2%) to 99.658% when pulling 25672a7 on feature/ctl_processor into bcdf228 on develop.

@KelSolaar KelSolaar force-pushed the feature/ctl_processor branch from abec73f to 9db3b99 Compare May 8, 2022 08:58
@KelSolaar KelSolaar force-pushed the feature/ctl_processor branch from 9db3b99 to 25672a7 Compare May 9, 2022 08:31
@KelSolaar KelSolaar marked this pull request as ready for review May 18, 2022 09:06
@KelSolaar
Copy link
Member Author

I will merge this one!

@KelSolaar KelSolaar merged commit 24708a0 into develop May 18, 2022
@KelSolaar KelSolaar deleted the feature/ctl_processor branch May 18, 2022 09:06
@KelSolaar KelSolaar added this to the v0.4.2 milestone Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-shaw nick-shaw Awaiting requested review from nick-shaw

@zachlewis zachlewis Awaiting requested review from zachlewis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@KelSolaar @coveralls