Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Implement support for "CIECAM16" colour appearance model. #1015

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

KelSolaar
Copy link
Member

@KelSolaar KelSolaar commented Jul 24, 2022

Summary

This PR implements support for "CIECAM16" colour appearance model as given by CIE 248:2022.

References #1013.

Preflight

Code Style and Quality

  • Unit tests have been implemented and passed.
  • Mypy static checking has been run and passed.
  • Pre-commit hooks have been run and passed.
  • New transformations have been added to the Automatic Colour Conversion Graph.
  • New transformations have been exported to the relevant namespaces, e.g. colour, colour.models.

Documentation

  • New features are documented along with examples if relevant.
  • The documentation is Sphinx and numpydoc compliant.

@coveralls
Copy link

coveralls commented Jul 24, 2022

Coverage Status

Coverage increased (+0.001%) to 99.836% when pulling 859982c on feature/ciecam16 into 0e76a57 on develop.

@KelSolaar KelSolaar marked this pull request as ready for review July 28, 2022 07:16
@KelSolaar
Copy link
Member Author

We do not compute hue composition because it is a bunch of Munsell Renotation System strings that are not super friendly for code that handles numbers mostly. I'm considering removing it from the various CAM specifications and provide a separate definition to compute it from hue/hue quadrature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants