-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#665 API to open and close inline-toolbar #711
Merged
neSpecc
merged 13 commits into
codex-team:release/2.13
from
tanmayv:api/open-close-inline-toolbar
Apr 11, 2019
Merged
Changes from 2 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
2691f14
API to open and close inline-toolbar
1cf996d
Fixed documentation
5b20b27
renamed inline -> inline-toolbar
tanmayv b6d0d3e
removed dist
tanmayv 516c32b
reset editor.js
tanmayv 41eb7e1
added editor.js bundle
tanmayv 1aa3f9f
Fixed build error
tanmayv aba49f1
Null checks on toolbar/inline@open
tanmayv 2dab7bf
updated bundle
tanmayv d2bdc88
Improve some comments
neSpecc 3bc1681
Updatd api.md CHANGELOG.md
tanmayv a815ac3
Merge branch 'api/open-close-inline-toolbar' of https://github.com/ta…
tanmayv 5eec988
Change feature to new instead of improvement
tanmayv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
import Module from '../../__module'; | ||
import { InlineToolbar } from '../../../../types/api/inline'; | ||
|
||
/** | ||
* @class InlineToolbarAPI | ||
* provides with methods working with InlineToolbar | ||
*/ | ||
export default class InlineToolbarAPI extends Module { | ||
/** | ||
* Available methods | ||
* @return {InlineToolbar} | ||
*/ | ||
get methods(): InlineToolbar { | ||
return { | ||
close: () => this.close(), | ||
open: () => this.open(), | ||
}; | ||
} | ||
|
||
/** | ||
* Open inlineToolbar | ||
*/ | ||
public open(): void { | ||
this.Editor.InlineToolbar.open(); | ||
} | ||
|
||
/** | ||
* Close inlineToolbar | ||
*/ | ||
public close(): void { | ||
this.Editor.InlineToolbar.close(); | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
/** | ||
* Describes InlineToolbar API methods | ||
*/ | ||
export interface InlineToolbar { | ||
/** | ||
* Closes InlineToolbar | ||
*/ | ||
close(): void; | ||
|
||
/** | ||
* Opens InlineToolbar | ||
*/ | ||
open(): void; | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neSpecc This file is also named
inline.ts
. Should we rename this as well?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, it's included at the
/toolbar/
directory, so this is a redundant addition