Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set --url in SSH config #470

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Set --url in SSH config #470

merged 1 commit into from
Aug 29, 2024

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Aug 27, 2024

This fixes an issue where you have CODER_URL in your environment but then connect to a different URL. The plugin will configure the settings file, but the cli will ignore it in favor of the environment variable. The flag is always preferred, so setting that ensures we use the right URL.

Unit tests show it gets added at least, but sure would be nice if we could test the flow. For now I manually set CODER_URL to something bogus when launching Gateway (like http://localhost:1234) then added a new connection as normal to dev.coder.com.

@code-asher code-asher force-pushed the asher/add-url branch 2 times, most recently from d18593d to dead511 Compare August 27, 2024 23:28
@code-asher code-asher marked this pull request as ready for review August 27, 2024 23:33
@code-asher code-asher requested a review from bcpeinhardt August 27, 2024 23:33
Copy link
Contributor

github-actions bot commented Aug 27, 2024

Qodana Community for JVM

4 new problems were found

Inspection name Severity Problems
Incorrect string capitalization 🔶 Warning 1
Usage of redundant or deprecated syntax or deprecated symbols 🔶 Warning 1
Redundant nullable return type 🔶 Warning 1
String concatenation that can be converted to string template ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/[email protected]
        with:
          upload-result: true
Contact Qodana team

Contact us at [email protected]

@code-asher code-asher merged commit 4cb1177 into main Aug 29, 2024
6 checks passed
@code-asher code-asher deleted the asher/add-url branch August 29, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant