Add Api Health checks #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianiftode
requested review from
aniri,
bvizureanu and
idormenco
as code owners
|
@aniri let me know if I should rebase, thanks |
@adrianiftode yes, it would be great if you could! thanks @idormenco could you please review this when you get some time? 🙏 |
- VotingMonitor health check - Redis health check - Windows Azure health check - Firebase health check Redis, Windows Azure and Firebase are configured to be checked only on specific conditions that depend on their configuration settings Runtime configuration changes are considered so if you enable a health check while the application is running, then this is executed otherwise the health check is tagged as not run Health Check endpoint /health is customized to include specific details for each health check The health checks are published on Application Insights
adrianiftode
force-pushed
the
health-check
branch
from
0e26230 to
d27884a
Compare
idormenco
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis, Windows Azure, and Firebase are configured
to be checked only on specific conditions
that depends on their configuration settings
Runtime configuration changes are considered
so if you enable a health check while the
application is running, then this is executed
otherwise, the health check is tagged as not run
Health Check endpoint /health is customized to
include specific details for each health check
The health checks are published on Application Insights.
The /health endpoint is not protected, so it is publicly accessible. This could be a potential security issue as it exposes the API dependencies.
What does it fix?
Closes #211
How has it been tested?
Enabling/disabling a health check is unit-tested
I manually tested Redis and VotingContext checks only. I also tested the /health endpoint.
I did not test Firebase and Azure Blob Storage, so suggest someone that has these dependencies to test them.
I also did not test the integration with Application Insights. It should periodically push the health checks status to Application Insights