-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added changes to track disk quota usage #4307
Conversation
…ile system is true
…b/codalab-worksheets into fix/4298-check-running-disk-quota
@AndrewJGaut what's the status of this PR? |
Haven't had time to get to it. The current Actions run is failing because of a hasty change I made, but if you look at this prior one (https://github.com/codalab/codalab-worksheets/actions/runs/4171333091/jobs/7491776164) it almost worked. The only thing is I think there's a race condition that I've been trying to fix but have been unsuccessful thus far. I don't think the issue really has to do with Kubernetes. |
@AndrewJGaut good to merge this now? |
I was going to mention this in meeting today, but we could merge now or we could do one more quick review (since I made some changes since last review). I think it's OK either way |
In meeting, we decided to merge this now. |
Reasons for making this change
We want to ensure that disk quota usage can be tracked for running bundles so that attackers can't zip bomb the system.
Related issues
Resolves issue #4298