Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure bypass-server upload to Azure timeout issue #4275

Merged
merged 4 commits into from
Oct 12, 2022
Merged

Fix Azure bypass-server upload to Azure timeout issue #4275

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c758b31
fix 4149
wwwjn Oct 7, 2022
67f2be6
more fix
wwwjn Oct 7, 2022
aafbf30
Merge branch 'master' into fix-4149
wwwjn Oct 10, 2022
9fc0536
Merge branch 'master' into fix-4149
wwwjn Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions codalab/lib/beam/blobstorageuploader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ class BlobStorageUploader(Uploader):
# size of 10 TiB to Blob Storage. To exceed that limit, we must either increase MIN_WRITE_SIZE
# or modify the implementation of this class to call commit_block_list more often (and not
# just at the end of the upload).
MIN_WRITE_SIZE = 100 * 1024 * 1024

# Set MIN_WRITE_SIZE to 20 MiB to prevent first put blob request timeout when uploading
MIN_WRITE_SIZE = 20 * 1024 * 1024
# Maximum block size is 4000 MiB (https://docs.microsoft.com/en-us/rest/api/storageservices/put-block#remarks).
MAX_WRITE_SIZE = 4000 * 1024 * 1024
# Set MAX_WRITE_SIZE to 50 MiB to prevent first put blob request timeout when uploading (https://github.com/Azure/azure-sdk-for-python/issues/12166)
MAX_WRITE_SIZE = 50 * 1024 * 1024

def __init__(self, client, path, mime_type='application/octet-stream'):
self._client = client
Expand Down