Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate remote field and make it copyable #4232

Merged
merged 4 commits into from
Aug 24, 2022
Merged

Conversation

leilenah
Copy link
Collaborator

@leilenah leilenah commented Aug 23, 2022

Reasons for making this change

The remote field is often long. The user doesn't need to be able to read the whole field, as it is usually a UUID. This changes truncates that uuid and makes it copyable (just like we do for the bundle's uuid).

This change also allows staged bundles to be killed from the bundle content CTAs.

Related issues

#4230

Screenshots

Before

Screen Shot 2022-08-22 at 5 49 32 PM

After

Screen Shot 2022-08-23 at 8 09 50 PM

Screen Shot 2022-08-23 at 8 08 59 PM

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@leilenah leilenah linked an issue Aug 23, 2022 that may be closed by this pull request
@percyliang
Copy link
Collaborator

Sometimes the remote is the hostname, so maybe we can show more of it (as much of it as you can without having it spill over)? What do you think, @teetone?

@leilenah
Copy link
Collaborator Author

@percyliang see revised screenshots in description

Copy link
Collaborator

@percyliang percyliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@leilenah leilenah merged commit c3f8126 into master Aug 24, 2022
@leilenah leilenah deleted the feature/4230-copy-remote branch August 24, 2022 17:48
@leilenah leilenah mentioned this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make remote field copyable in bundle detail sidebar
2 participants