Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up local reloading by updating Dockerfiles to run "pip install" before copying over code #4202

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

epicfaace
Copy link
Member

@epicfaace epicfaace commented Aug 10, 2022

Reasons for making this change

Improves experience for #4199, since "pip install" is one of the most time-intensive steps that happen when rebuilding Docker containers locally during development.

Related issues

Screenshots

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@epicfaace epicfaace changed the title Update Dockerfile.worker Speed up local reloading by updating Dockerfiles to run "pip install" before copying over code Aug 10, 2022
@epicfaace epicfaace requested a review from leilenah August 10, 2022 20:03
@epicfaace epicfaace marked this pull request as ready for review August 10, 2022 20:03
@mergify mergify bot merged commit 4b78fa7 into master Aug 11, 2022
@mergify mergify bot deleted the epicfaace-patch-16 branch August 11, 2022 00:57
@leilenah leilenah mentioned this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants