Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: remove unwrapMVCCScan #44823 #44946

Merged
merged 1 commit into from
Feb 11, 2020
Merged

Conversation

C0rWin
Copy link
Contributor

@C0rWin C0rWin commented Feb 10, 2020

This PR Refactors pkg/storage/engine/mvcc_test.go.
*Modifies mvcc_test.go to clean up and remove unwrapMVCCScan.

Fixes #44823.

Release note: None

This PR Refactors pkg/storage/engine/mvcc_test.go.
*Modifies mvcc_test.go to clean up and remove unwrapMVCCScan.

Release note: None

Signed-off-by: Artem Barger <[email protected]>
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@claassistantio
Copy link

claassistantio commented Feb 10, 2020

CLA assistant check
All committers have signed the CLA.

@C0rWin C0rWin requested a review from tbg February 11, 2020 08:50
@tbg
Copy link
Member

tbg commented Feb 11, 2020

Thank you, @C0rWin!

bors r=tbg

craig bot pushed a commit that referenced this pull request Feb 11, 2020
44946: engine: remove unwrapMVCCScan #44823 r=tbg a=C0rWin

This PR Refactors pkg/storage/engine/mvcc_test.go.
*Modifies mvcc_test.go to clean up and remove unwrapMVCCScan.

Release note: None

Signed-off-by: Artem Barger <[email protected]>

Co-authored-by: Artem Barger <[email protected]>
@craig
Copy link
Contributor

craig bot commented Feb 11, 2020

Build succeeded

@craig craig bot merged commit 11ac750 into cockroachdb:master Feb 11, 2020
@C0rWin C0rWin deleted the fix#44823 branch March 4, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

engine: remove unwrapMVCCScan
4 participants