Update of Millepede production system (MPS): large campaigns #47080
+182
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-47080/43260 |
|
A new Pull Request was created by @rmankel for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
rmankel
added a commit
to rmankel/cmssw
that referenced
this pull request
Jan 10, 2025
rmankel
added a commit
to rmankel/cmssw
that referenced
this pull request
Jan 10, 2025
perrotta
reviewed
Jan 11, 2025
| @@ -369,6 +393,10 @@ | |||
| farmhost = ' ' | |||
|
|
|||
| okStatus = 'OK' | |||
| if badInputFile == 1: | |||
There was a problem hiding this comment.
With this structure, if more than one error is issued, the last error conditions will overwrite okStatus and remark for all previous ones: is it acceptable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
The Millepede production system (MPS) is updated. The main improvements are:
The changes have been detailed in the following presentation: https://indico.cern.ch/event/1363492/#26-update-for-the-millepede-pr
PR validation:
Code checks. Code format. Unit tests done.
The changes concern only python scripts that are used exclusively by the MPS system. They are not used by any other code in CMS.